Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never hide backslash escapes in fontified code blocks #836

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jimporter
Copy link
Contributor

Description

Previously, if hiding markup and using native fontification of code blocks, backslash escapes could get hidden inside code. To fix this, we just need to mark markdown-code-face as a literal face.

Related Issue

#766 (see the end of the discussion).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

Previously, if hiding markup and using native fontification of code blocks,
backslash escapes could get hidden inside code. See jrblevin#766.
@syohex syohex merged commit 8a7773f into jrblevin:master Jul 16, 2024
4 checks passed
@syohex
Copy link
Collaborator

syohex commented Jul 16, 2024

Thanks

@jimporter
Copy link
Contributor Author

Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants