Fix the error in case of no-cb require(["deps"])

[ghost]

The require(["deps"]); fails as amdefine tries to call the callback unconditionally.

[jrburke]

Ah good idea. I just have one nit, to use braces with the if body, and a 4 space indentation to match the rest of the file.

If you want to update the pull request to that, that would be ideal. If you just wanted to report the issue and are OK with me doing the change myself on master with that style, then let me know and I will do it.

[ghost]

Just do it yourself, I edited in github itself, I don't know how / if ever I can fix it there.

James Burke wrote:

Ah good idea. I just have one nit, to use braces with the if body, and
a 4 space indentation to match the rest of the file.

If you want to update the pull request to that, that would be ideal.
If you just wanted to report the issue and are OK with me doing the
change myself on master with that style, then let me know and I will
do it.

—
Reply to this email directly or view it on GitHub
#26 (comment).

[ghost]

I did a change in bracing; as for spaces, I don't know what was the problem, I see them there in the diff...

[jrburke]

Merged and released 0.1.1 with the change.

[ghost]

Thanks, not it will work with optimizer's insertRequire ;-)

James Burke wrote:

Merged and released 0.1.1 with the change.

—
Reply to this email directly or view it on GitHub
#26 (comment).