object.split problem in requirejs

[ORESoftware]

I found a weird bug on line 276 of require.js, in the function called "normalize"

the problem was that 'name' was an object in the code (typeof name === 'object') and split was called on that object which causes problems

if (name) {
    name = name.split('/');  //error here: "name.split is not a function"

to generalize, when you call

var obj = {};
obj.split('') // will throw "obj.split is not a function"

so this solves the problem

name = String(name).split('/');

but I believe you might want to examine require.js to see why an object ended up in the normalize function in your codebase

thanks

[ORESoftware]

I mean, my usage of the library put the object there somehow, but it seems like maybe something could be a little off

[jrburke]

It would be good to have a use case or description on how this condition occurred, to know what entry point the non-string object came into the require() or define() APIs to get to that condition. It is costly to file size to put type checks in every function, ideally the issues are caught at the public entry points.

[ORESoftware]

sure I understand, I will give you more context in the next 48 hours

[rjgotten]

It would be good to have a use case or description on how this condition occurred

A trailing comma in the dependency array is enough to trigger this problem. I've had it happen numerous times myself.