Nonce is sometimes shorter than expected #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknown8063
changed the title
unknown8063
changed the title
|
Ugh, sorry about that. Any reason you're killing the exception logging code? |
|
Sorry, I didn't realize the pull request would grow when I checked in additional changes. I've backed it out. |
jrconlin
added a commit
that referenced
this pull request
May 24, 2014
Nonce is sometimes shorter than expected
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every once in a while my OAuth requests would fail with an authorization denied error. I eventually noticed that every failed request I sent had a 4 character nonce, which seems a bug since _getNonce() is given a length of 5 in the code.
When $rnum is exactly equal to the length of the string $_nonce_chars, the substring it extracts ends up being the empty string, which causes a shorter nonce than expected. The solution is to restrict $rnum to be between 0 and $cLength-1.
BTW, thanks for the library :)