Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] fork has deviated from mainstream a lot #64

Closed
jrddunbr opened this issue Nov 6, 2018 · 0 comments
Closed

[meta] fork has deviated from mainstream a lot #64

jrddunbr opened this issue Nov 6, 2018 · 0 comments
Assignees
Milestone

Comments

@jrddunbr
Copy link
Collaborator

jrddunbr commented Nov 6, 2018

This fork has deviated quite a bit from upstream, enough that it has some things that break existing game-play of the upstream to the point where it is incompatible with "normal" builds of Electrical Age on CurseForge and the main repository, and it will crash the client (or server), guaranteed.

We should definitely make sure that it's clear that this is not an official (stable?) Electrical Age build. Perhaps some changes to the main README.md is in order, specifically, we're not tied into Travis builds on this fork right now, among other things such as the license status indicator for upstream, and perhaps we can give more helpful information about how to build and other things. Importantly, we will change the version numbering in the repository itself (specifically in the Gradle configurations) and list it as being built from the fork, to make sure that we don't confuse the developers of the mod on either development path.

I intend to not separate the Electrical Age community by doing this, but rather to create a more clear fork of the development efforts that will eventually merge back into upstream, either at 1.7.10 when stable, or at 1.10+ when that is ready.

I also want to make it very clear with a (compatible) license file addition, that any changes accepted here are explicitly allowed to be merged back into the upstream, if it isn't already by the nature of the license.

Feel free to comment with thoughts and direction on this topic.

@jrddunbr jrddunbr self-assigned this Nov 6, 2018
@jrddunbr jrddunbr added the meta label Nov 6, 2018
@jrddunbr jrddunbr pinned this issue Jan 2, 2019
This was referenced Jan 9, 2019
@jrddunbr jrddunbr added this to the LLv12 milestone Jan 18, 2019
@jrddunbr jrddunbr unpinned this issue Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant