Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packagers] asdf.repository does not inherit name from parent packager #1592

Closed
3 of 4 tasks
aalmiray opened this issue Feb 8, 2024 · 2 comments
Closed
3 of 4 tasks
Assignees
Labels
bug Something isn't working released Issue has been released
Milestone

Comments

@aalmiray
Copy link
Member

aalmiray commented Feb 8, 2024

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem (link to git repository is ideal)
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. clone https://github.com/jreleaser/helloworld-java-bin
  2. edit jreleaser.yml and add the following
packagers:
  asdf:
    active: ALWAYS
    repository:
      owner: aalmiray
      username: aalmiray
      name: asdf-test
  1. execute jreleaser config and inspect the result
packagers:
    asdf:
        enabled: true
        active: ALWAYS
        continueOnError: false
        commitAuthor:
            name: jreleaserbot
            email: jreleaser@kordamp.org
        repository:
            enabled: false
            owner: aalmiray
            name: asdf-test
            tagName: v{{projectVersion}}
            branch: HEAD
            branchPush: HEAD
            username: jreleaser
            token: ************
 
distributions:
    helloworld:
        enabled: true
        active: ALWAYS
        type: JAVA_BINARY
        executable:
            name: helloworld
            windowsExtension: bat
        artifacts:
            artifact 0:
                enabled: true
                active: ALWAYS
                path: /private/tmp/helloworld-java-bin/out/jreleaser/assemble/helloworld/java-archive/helloworld-1.0.0.zip
        stereotype: CLI
        java:
            enabled: true
            version: 11
            groupId: test.jreleaser
            artifactId: helloworld
            mainClass: org.jreleaser.examples.HelloWorld
            multiProject: false
        asdf:
            enabled: true
            active: ALWAYS
            continueOnError: false
            templateDirectory: src/jreleaser/distributions/helloworld/asdf
            commitAuthor:
                name: jreleaserbot
                email: jreleaser@kordamp.org
            toolcheck: {{distributionExecutable}} --version
            repository:
                enabled: true
                active: RELEASE
                owner: aalmiray
                name: asdf-helloworld
                tagName: v{{projectVersion}}
                branch: HEAD
                branchPush: HEAD
                username: jreleaser
                token: ************
                commitMessage: {{distributionName}} {{tagName}}

Expected Behaviour

The asdf section at the helloworld distribution shows asdf-helloworld as the resolved name

Actual Behaviour

Resolved name should be asdf-test as that is the value set in the parent packager.

Environment Information

  • Operating System: OSX
  • JReleaser Version: 1.10.0
  • JDK Version: 17
@aalmiray aalmiray added the bug Something isn't working label Feb 8, 2024
@aalmiray aalmiray added this to the v1.11.0 milestone Feb 8, 2024
@aalmiray
Copy link
Member Author

aalmiray commented Feb 8, 2024

These packagers are also affected:

  • appimage
  • jib
  • winget

@aalmiray aalmiray self-assigned this Feb 9, 2024
@aalmiray
Copy link
Member Author

🎉 This issue has been resolved in v1.11.0 (Release Notes)

@aalmiray aalmiray added the released Issue has been released label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue has been released
Projects
None yet
Development

No branches or pull requests

1 participant