Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deploy] Signature and checksum files are not checked for newer timestamp #1625

Closed
2 of 4 tasks
aalmiray opened this issue Mar 24, 2024 · 1 comment
Closed
2 of 4 tasks
Assignees
Labels
bug Something isn't working released Issue has been released
Milestone

Comments

@aalmiray
Copy link
Member

aalmiray commented Mar 24, 2024

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem (link to git repository is ideal)
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. Configure a project as explained at https://jreleaser.org/guide/latest/examples/maven/maven-central.html
  2. Stage all artifacts with mvn -Ppublication
  3. Perform a deployment in dry run mode with mvn jreleaser:deploy -Djreleaser.dry.run=true
  4. Stage all artifacts once again
  5. Perform yet another deployment in dry run mode

Expected Behaviour

Signature and checksum files should have updated timestamps, equal or greater than the artifacts they relate to.

Actual Behaviour

Timestamps remain unchanged.

Staged artifacts

.rw-r--r-- 143k aalmiray 24 Mar 19:16 -I record-args-0.5.0-javadoc.jar
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0-javadoc.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0-javadoc.jar.sha1
.rw-r--r--  17k aalmiray 24 Mar 19:16 -I record-args-0.5.0-sources.jar
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0-sources.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0-sources.jar.sha1
.rw-r--r--  50k aalmiray 24 Mar 19:16 -I record-args-0.5.0.jar
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0.jar.sha1
.rw-r--r-- 6.9k aalmiray 24 Mar 19:16 -I record-args-0.5.0.pom
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0.pom.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0.pom.sha1

1st deployment

.rw-r--r-- 143k aalmiray 24 Mar 19:16 -I record-args-0.5.0-javadoc.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0-javadoc.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0-javadoc.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.sha512
.rw-r--r--  17k aalmiray 24 Mar 19:16 -I record-args-0.5.0-sources.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0-sources.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0-sources.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.sha512
.rw-r--r--  50k aalmiray 24 Mar 19:16 -I record-args-0.5.0.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.sha512
.rw-r--r-- 6.9k aalmiray 24 Mar 19:16 -I record-args-0.5.0.pom
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.asc
.rw-r--r--   32 aalmiray 24 Mar 19:16 -I record-args-0.5.0.pom.md5
.rw-r--r--   40 aalmiray 24 Mar 19:16 -I record-args-0.5.0.pom.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.sha512

Second staging. Note that all JARs, md5, and sha1 files have been updated

.rw-r--r-- 143k aalmiray 24 Mar 19:18 -I record-args-0.5.0-javadoc.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0-javadoc.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0-javadoc.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.sha512
.rw-r--r--  17k aalmiray 24 Mar 19:18 -I record-args-0.5.0-sources.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0-sources.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0-sources.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.sha512
.rw-r--r--  50k aalmiray 24 Mar 19:18 -I record-args-0.5.0.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.sha512
.rw-r--r-- 6.9k aalmiray 24 Mar 19:18 -I record-args-0.5.0.pom
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0.pom.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0.pom.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.sha512

Second deployment. Signatures and sha256/sha512 checksums were not updated

.rw-r--r-- 143k aalmiray 24 Mar 19:18 -I record-args-0.5.0-javadoc.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0-javadoc.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0-javadoc.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0-javadoc.jar.sha512
.rw-r--r--  17k aalmiray 24 Mar 19:18 -I record-args-0.5.0-sources.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0-sources.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0-sources.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0-sources.jar.sha512
.rw-r--r--  50k aalmiray 24 Mar 19:18 -I record-args-0.5.0.jar
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0.jar.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0.jar.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0.jar.sha512
.rw-r--r-- 6.9k aalmiray 24 Mar 19:18 -I record-args-0.5.0.pom
.rw-r--r--  824 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.asc
.rw-r--r--   32 aalmiray 24 Mar 19:18 -I record-args-0.5.0.pom.md5
.rw-r--r--   40 aalmiray 24 Mar 19:18 -I record-args-0.5.0.pom.sha1
.rw-r--r--   64 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.sha256
.rw-r--r--  128 aalmiray 24 Mar 19:17 -I record-args-0.5.0.pom.sha512

Environment Information

  • Operating System: N/A
  • JReleaser Version: 1.11.0
  • JDK Version: N/A

Discovered by @nipafx at #1624

@aalmiray aalmiray added the bug Something isn't working label Mar 24, 2024
@aalmiray aalmiray self-assigned this Mar 24, 2024
@aalmiray aalmiray added this to the v1.12.0 milestone Mar 24, 2024
@aalmiray aalmiray added the released Issue has been released label May 1, 2024
@aalmiray
Copy link
Member Author

aalmiray commented May 1, 2024

🎉 This issue has been resolved in v1.12.0 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue has been released
Projects
None yet
Development

No branches or pull requests

1 participant