Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deploy] Provide additional information when reading public key #1626

Closed
aalmiray opened this issue Mar 24, 2024 · 1 comment
Closed

[deploy] Provide additional information when reading public key #1626

aalmiray opened this issue Mar 24, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers released Issue has been released
Milestone

Comments

@aalmiray
Copy link
Member

Reading a public key from a misconfigured or badly formatted source leads to an error such as

Did not find public key for signing

try {
publicKeyID = SigningUtils.getPublicKeyID(context.asImmutable());
} catch (SigningException e) {
context.getLogger().warn(RB.$("ERROR_public_key_not_found"));
return;
}

Proposed solution:

Update the value of the following keys in https://github.com/jreleaser/jreleaser/blob/main/api/jreleaser-resource-bundle/src/main/resources/org/jreleaser/bundle/Messages.properties:

ERROR_public_key_not_found
ERROR_secret_key_not_found

To include a message such as:

Ensure a value has been configured and properly formatted without indentation.
@aalmiray aalmiray added enhancement New feature or request good first issue Good for newcomers labels Mar 24, 2024
@aalmiray aalmiray added this to the v1.12.0 milestone Mar 24, 2024
@aalmiray aalmiray self-assigned this Apr 10, 2024
@aalmiray aalmiray added the released Issue has been released label May 1, 2024
@aalmiray
Copy link
Member Author

aalmiray commented May 1, 2024

🎉 This issue has been resolved in v1.12.0 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers released Issue has been released
Projects
None yet
Development

No branches or pull requests

1 participant