Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle quiet mode #768

Closed
4 tasks
yschimke opened this issue Feb 20, 2022 · 4 comments
Closed
4 tasks

Handle quiet mode #768

yschimke opened this issue Feb 20, 2022 · 4 comments
Assignees
Labels
cli Affects CLI enhancement New feature or request gradle Affects Gradle plugins maven Affects Maven plugins
Milestone

Comments

@yschimke
Copy link

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem (link to git repository is ideal)
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. Run a build with ./gradlew -q ...
  2. observe only output is from jreleaser

Expected Behaviour

No output in quiet mode

Actual Behaviour

signing.args has been deprecated since 1.0.0-M1 and will be removed in the future. Use signing.command.args instead
signing.args has been deprecated since 1.0.0-M1 and will be removed in the future. Use signing.command.args instead

plus a patreon message.

Environment Information

  • Operating System: OSX M1
  • JReleaser Version: 1.0.0-M1
  • JDK Version: 17
@yschimke yschimke added the bug Something isn't working label Feb 20, 2022
@aalmiray
Copy link
Member

Deprecation warnings will disappear once v1.0.0 comes out.

The patreon banner appears in the first 3 invocations of the plugin, although it might be a recurrent output on CI if the ~/.jreleaser is not cached.

This being said, having a "quiet" mode in core which may be activated via its executing interfaces (cli, maven, gradle, ant) is a good idea.

@aalmiray aalmiray added enhancement New feature or request and removed bug Something isn't working labels Feb 20, 2022
@aalmiray
Copy link
Member

Moreover, the cli already has a quiet flag which as it turns out activates the ERROR log level. It'll have to be remapped.

@yschimke
Copy link
Author

This is not critical, but the reason it's relevant for me, is that for my CLI the release build is with native image.

But for quick development I have a command line script checked into github to build with gradle and then run.

https://github.com/yschimke/okurl/blob/main/okurl

@aalmiray
Copy link
Member

Got it. I can work sometime out soon.

@aalmiray aalmiray changed the title Gradle quiet mode Handle quiet mode Feb 20, 2022
@aalmiray aalmiray added this to the v1.0.0-RC1 milestone Feb 20, 2022
@aalmiray aalmiray added cli Affects CLI gradle Affects Gradle plugins maven Affects Maven plugins labels Feb 20, 2022
@aalmiray aalmiray self-assigned this Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Affects CLI enhancement New feature or request gradle Affects Gradle plugins maven Affects Maven plugins
Projects
None yet
Development

No branches or pull requests

2 participants