Had to turn off fastmath
for nbrk_ode
#24
Labels
bug
Something isn't working
help wanted
Extra attention is needed
nbrk_ode
An issue with the Numba solver
performance
Issues related to improving performance
Prior to v0.5.0, numba's
fastmath
variable was turned on fornbrk_ode
. With the fix to issue #20 in PR #23 we noticed that the standard set of tests would fail on MacOS and Ubuntu systems. It was very random, even rerunning a test without a change in code could cause different results.Some consistent findings:
fastmath=False
(in CyRK.nb.nbrk at the njit decorator) allowed tests to pass.PR #23 changed the way minimum step size was calculated. Prior to this change it was set to:
now it is set, correctly, to
For small
t
this value is quite small (5e-323 vs. a EPS of ~1e-16). I believe there is something not playing well between this small value floating around (pun) while fastmath is on. At least on some operating systems.It is more important that the step size is set correctly so, as of 0.5.0, fastmath is turned off for
nbrk_ode
there is a slight performance hit with this change.The text was updated successfully, but these errors were encountered: