Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building wheels for CyRK does not package cython's binaries for PyPI distribution #9

Closed
jrenaud90 opened this issue Dec 30, 2022 · 6 comments
Milestone

Comments

@jrenaud90
Copy link
Owner

See details (and hopefully a future solution) about this issue here.

Current workaround is to not build or upload wheels during CI. Users will have to recompile the cython code locally as of CyRK v0.2.0.

@jrenaud90 jrenaud90 added help wanted Extra attention is needed cython Issue related to cython-based code distribution Issues related to distribution, installation, or compilation. labels Dec 30, 2022
@jrenaud90 jrenaud90 added this to the 1.0.0 milestone Dec 30, 2022
@cerrussell
Copy link
Contributor

I can help with this. cibuildwheel really simplifies the build process.

@jrenaud90
Copy link
Owner Author

Hey @cerrussell! It would be great to have your help. I did look at cibuildwheel before but was running into a similar error as described in the top post,

cibuildwheel: Build failed because a pure Python wheel was generated.
  
  If you intend to build a pure-Python wheel, you don't need cibuildwheel - use
  `pip wheel -w DEST_DIR .` instead.

It would be awesome if you have any insights on how to make it work, feel free to make a PR.

@cerrussell
Copy link
Contributor

@jrenaud90 Yeah, I got that too - I think it's because you have to tell your setuptools backend what extensions you expect it to include. I resolved that bit on my fork, but running into some odd compilation issues related to numpy that I'm hammering out now.

@cerrussell
Copy link
Contributor

@jrenaud90 Just created a pull request... looks like wheels are being generated properly. Still some work to do - adding testing to cibuildwheels and a command to unpack the wheels to show they include the prebuilt binary.

@jrenaud90
Copy link
Owner Author

Awesome! Thank you so much for your help. I will take a look at it later today.

@jrenaud90 jrenaud90 removed help wanted Extra attention is needed cython Issue related to cython-based code distribution Issues related to distribution, installation, or compilation. labels Jan 3, 2023
@jrenaud90
Copy link
Owner Author

Fixed with PR #15 in CyRK v0.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants