-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-9: Precompiled binary builds #15
Conversation
…e it. The docs for setuptools indicated a setup.py would be needed in addition to the toml. https://setuptools.pypa.io/en/latest/userguide/ext_modules.html
…e it. The docs for setuptools indicated a setup.py would be needed in addition to the toml. https://setuptools.pypa.io/en/latest/userguide/ext_modules.html
Install build reqs before build
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 5
Lines 418 418
=====================================
Misses 418 418
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hey @cerrussell, I just tested this locally on windows and ubuntu and it works great! |
Tested the new CI publish on a different branch pointing to test.pypi and it ran successfully & I was able to install from pypi on both windows and ubuntu. Looks like we are in good shape! |
Great! |
The last workflow run on my fork was successful in building everything. It is difficult to tell that the binary extension is being included from the logs - however, I also ran this configuration locally for Windows and the pyd file was included in the generated wheels. I will try to add a script at the end to unpack and list the contents of the wheels. The other thing that needs to be added is testing.