Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-9: Precompiled binary builds #15

Merged
merged 21 commits into from
Jan 3, 2023
Merged

Issue-9: Precompiled binary builds #15

merged 21 commits into from
Jan 3, 2023

Conversation

cerrussell
Copy link
Contributor

The last workflow run on my fork was successful in building everything. It is difficult to tell that the binary extension is being included from the logs - however, I also ran this configuration locally for Windows and the pyd file was included in the generated wheels. I will try to add a script at the end to unpack and list the contents of the wheels. The other thing that needs to be added is testing.

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (4d44639) compared to base (fef2398).
Patch has no changes to coverable lines.

❗ Current head 4d44639 differs from pull request most recent head 0f04437. Consider uploading reports for the commit 0f04437 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #15   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          5       5           
  Lines        418     418           
=====================================
  Misses       418     418           
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jrenaud90
Copy link
Owner

Hey @cerrussell, I just tested this locally on windows and ubuntu and it works great!

@jrenaud90
Copy link
Owner

jrenaud90 commented Jan 2, 2023

Tested the new CI publish on a different branch pointing to test.pypi and it ran successfully & I was able to install from pypi on both windows and ubuntu. Looks like we are in good shape!

@cerrussell
Copy link
Contributor Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants