Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dr. Mingw About dialog and version information #76

Merged
merged 1 commit into from Oct 3, 2022

Conversation

Robyt3
Copy link
Contributor

@Robyt3 Robyt3 commented Oct 2, 2022

  • Add version information to About dialog.
  • Show full copyright instead of author in About dialog.
  • Show "Dr. Mingw" as product name in version information instead of "DrMingw".
  • The macro VER_PRODUCTVERSION_MAJORMINORPATCH2 no longer adds additional zero-termination to the version string, as this would prematurely end strings using this macro.

Before:

about old

After:

about new

Closes #56.

- Add version information to About dialog.
- Show full copyright instead of author in About dialog.
- Show "Dr. Mingw" as product name in version information instead of "DrMingw".
- The macro `VER_PRODUCTVERSION_MAJORMINORPATCH2` no longer adds additional zero-termination to the version string, as this would prematurely end strings using this macro.
@codecov-commenter
Copy link

Codecov Report

Merging #76 (820c47f) into master (52c36c7) will decrease coverage by 2.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   50.66%   48.47%   -2.20%     
==========================================
  Files          15       15              
  Lines        1954     1931      -23     
  Branches      742      733       -9     
==========================================
- Hits          990      936      -54     
- Misses        743      768      +25     
- Partials      221      227       +6     
Impacted Files Coverage Δ
src/common/log.cpp 58.00% <0.00%> (-6.04%) ⬇️
src/mgwhelp/mgwhelp.cpp 61.01% <0.00%> (-3.52%) ⬇️
src/common/debugger.cpp 42.94% <0.00%> (-2.85%) ⬇️
src/mgwhelp/dwarf_pe.cpp 83.33% <0.00%> (-1.63%) ⬇️
src/catchsegv/catchsegv.cpp 44.97% <0.00%> (-0.92%) ⬇️
src/mgwhelp/dwarf_find.cpp 48.17% <0.00%> (-0.61%) ⬇️
src/common/symbols.cpp 73.91% <0.00%> (-0.56%) ⬇️
src/addr2line/addr2line.cpp 50.98% <0.00%> (-0.48%) ⬇️
src/exchndl/exchndl.cpp 74.35% <0.00%> (-0.22%) ⬇️
src/drmingw/main.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jrfonseca jrfonseca merged commit e140404 into jrfonseca:master Oct 3, 2022
@jrfonseca
Copy link
Owner

Thanks.

@Robyt3 Robyt3 deleted the DrMingw-About-Dialog branch October 3, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dr.mingw version in the GUI
3 participants