Added an Opacity Feature to the Note Histogram #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated this so the note histogram is not faded when there is only one file. |
|
lgtm!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pair of bars are the same, we decrease their opacity to 0.2. This allows bars with errors to stick out. I've edited one of the Mario files to have a handful of note errors.
I just realized that it's possible to have all the right notes and play them in the wrong place, so the note histogram can look correct and you'd still be playing the song wrong. 🤣
Also, I think we should not fade if you only have one file, but I haven't added that feature. The graph is faded by default.