Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fn(s) that accept 'filename' as str to use PathBuf instead #47

Closed
jczuluag opened this issue Mar 27, 2021 · 0 comments · Fixed by #48
Closed

Refactor fn(s) that accept 'filename' as str to use PathBuf instead #47

jczuluag opened this issue Mar 27, 2021 · 0 comments · Fixed by #48
Assignees

Comments

@jczuluag
Copy link
Collaborator

jczuluag commented Mar 27, 2021

Some functions accept a string to handle filesystem names, which can lead to error prone behavior.
The signature of the function should be more specific in order to handle only filesystem type of arguments. In this case PathBuf could help to handle those scenarios.

@jczuluag jczuluag changed the title Refactor fn that accept 'filename' to use PathBuf instead Refactor fn(s) that accept 'filename' to use PathBuf instead Mar 27, 2021
@jczuluag jczuluag changed the title Refactor fn(s) that accept 'filename' to use PathBuf instead Refactor fn(s) that accept 'filename' as str to use PathBuf instead Mar 27, 2021
@jczuluag jczuluag self-assigned this Mar 28, 2021
mulark pushed a commit that referenced this issue Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant