Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

Add support for Sidekiq 3.x #89

Merged
merged 1 commit into from May 16, 2014
Merged

Conversation

mrnugget
Copy link

It seems like the API that delayed_paperclip uses internally doesn't change from Sidekiq 2.x to 3.x. The only thing that changed is that you now have to explicitly require sidekiq/api in the test files to get access to Sidekiq::Queue. Changing require sidekiq to require sidekiq/api seems to work with both Sidekiq versions. At least it works for me locally with and without an update to Sidekiq 3.x.

@ScotterC
Copy link
Collaborator

Thanks!

From your knowledge, this is backwards compatible?

@mrnugget
Copy link
Author

Yep, the require 'sidekiq/api' works both with Sidekiq 2.x and 3.x.

>> require 'sidekiq/api'
=> true
>> Sidekiq::VERSION
=> "2.17.7"

And the API that delayed_paperclip uses did not change (or otherwise the tests would break, which they do not).

@ScotterC
Copy link
Collaborator

Great!

ScotterC added a commit that referenced this pull request May 16, 2014
@ScotterC ScotterC merged commit 2cbc1dd into jrgifford:master May 16, 2014
@mrnugget
Copy link
Author

Thanks for merging this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants