Escape shell vars in HCL output #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhouston
commented
Aug 28, 2021
| @@ -88,6 +88,12 @@ func snakify(s string) string { | |||
| return strings.ToLower(re.ReplaceAllString(s, "_")) | |||
| } | |||
|
|
|||
| // escape incidences of ${} with $${} to prevent Terraform trying to interpolate them | |||
| func escapeShellVars(s string) string { | |||
| r := regexp.MustCompile(`(\${.*?})`) | |||
There was a problem hiding this comment.
The .*? here is to make the regexp not greedy – otherwise it would match ${VAR1} ${VAR2} as one group.
jrhouston
commented
Aug 28, 2021
| // escape incidences of ${} with $${} to prevent Terraform trying to interpolate them | ||
| func escapeShellVars(s string) string { | ||
| r := regexp.MustCompile(`(\${.*?})`) | ||
| return r.ReplaceAllString(s, `$$$1`) |
There was a problem hiding this comment.
There is three $ because $1 uses the first group, then we need to escape the $ we want to put in front of it 😅
|
@curtbushko if you want to try this for your use case and make sure it works. |
|
Just tried the with the manifest mentioned in the issue and it validates successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27