no separate heap alloc for prngSeed

jrick · Jun 19, 2024 · e821a53 · e821a53
1 parent 71fb3fa
commit e821a53
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/mixing/mixclient/client.go b/mixing/mixclient/client.go
@@ -174,7 +174,7 @@ type peer struct {
 	coinjoin *CoinJoin
 	kx       *mixing.KX
 
-	prngSeed *[32]byte
+	prngSeed [32]byte
 	prng     *chacha20prng.Reader
 
 	rs    *wire.MsgMixSecrets
@@ -1094,7 +1094,6 @@ func (c *Client) run(ctx context.Context, ps *pairedSessions, madePairing *bool)
 
 		if sesRun.freshGen {
 			// Generate a new PRNG seed
-			p.prngSeed = new([32]byte)
 			rand.Read(p.prngSeed[:])
 			p.prng = chacha20prng.New(p.prngSeed[:], 0)
 
@@ -1137,7 +1136,7 @@ func (c *Client) run(ctx context.Context, ps *pairedSessions, madePairing *bool)
 			srMsgBytes[i] = p.srMsg[i].Bytes()
 		}
 		rs := wire.NewMsgMixSecrets(*p.id, sesRun.sid, 0,
-			*p.prngSeed, srMsgBytes, p.dcMsg)
+			p.prngSeed, srMsgBytes, p.dcMsg)
 		c.blake256HasherMu.Lock()
 		commitment := rs.Commitment(c.blake256Hasher)
 		c.blake256HasherMu.Unlock()