This repository has been archived by the owner on Apr 29, 2021. It is now read-only.
Child assignmentexpressions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also hoist them above the `jsxWrapper`, if we’re going to create one.
If there is a `containingJSXElement`, we would have already searched for other JSX elements on it.
Also cleans up all the data we’re passing around. 😄
|
Ping @thejameskyle, I think it's ready for a code review now. |
|
I'll try to remember for later tonight |
|
Ping. 😃 |
Open
|
|
||
| file.path.unshiftContainer("body", helperAstFn(t, helperRef, dependencyRefs)); | ||
|
|
||
| for (let dependency of undefinedDeps) { |
There was a problem hiding this comment.
Can you remove this for...of? This will depend on the polyfill
|
This looks really good. Sorry for taking so long to review it |
| let key = null; | ||
| let statics = []; | ||
|
|
||
| for (let attribute of attributes) { |
There was a problem hiding this comment.
Should I remove this for ... of, too?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8.
Code needs to be cleaned up a bit, and I need to rewrite the commit history. But, I'd rather get some input into how we can break this implementation before I spend time cleaning it up.