Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #9

Open
wants to merge 141 commits into
base: master
Choose a base branch
from
Open

V2 #9

wants to merge 141 commits into from

Conversation

jridgewell
Copy link
Owner

TODO:

Back burner:

  • Look into Marionette.Behavior
    • Dislike wrapping functions and events.
  • CollectionView #filter
    • All kinds of problems and tons of code. Best left to a virtual Collection.

Additions:

  • Adds Router
  • View
    • Add ui hash
  • Adds trigger function
    • To be mixed into subclasses, at the Dev's discretion.

Changes:

  • Region
    • Trigger detach and detached events when attaching a new view
    • Optimize when a Region's view is removed.
    • Extract placeholder into a Backbone.View class
    • remove #detach and #reattach
  • View
    • Optimize rendering a string template.
    • Do not render a Region's placeholder view when using <%= view('name' %> template syntax
    • Regions are no longer attached at the root.
  • CollectionView
    • Separate out logic for appending and appending-to Document Fragments
      • This was unnecessarily complex. At times, you would be appending a single modelView. Other times, you would be appending a Backbone.View who's #el was a frag.

Misc Changes

  • Convert Grunt -> Gulp
  • Cleanup JSHint

@coveralls
Copy link

Coverage Status

Coverage increased (+1.37%) when pulling 76cbf49 on v2 into d497fc7 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants