New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const enum for UrlType #120

Merged

jridgewell merged 1 commit into jridgewell:main from sapphi-red:main

Feb 14, 2024

Contributor

sapphi-red commented Feb 14, 2024

This PR changes UrlType type to const enum from enum.

This change makes this package

UrlType tree-shake friendly
- TypeScript enum cannot be tree-shaked but const enum can be
smaller
- The file size with terser is reduced by ~18% (before: 2303B, after: 1891B)


          Use const enum for UrlType

3b69ba0

jridgewell approved these changes

View reviewed changes

Owner

jridgewell commented Feb 14, 2024

Excellent, thanks!

jridgewell merged commit e4b1e34 into jridgewell:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment