Fix #169 - Updates deprecated STATICFILES_STORAGE to STORAGES #173
Conversation
bruunotrindade
force-pushed
the
master
branch
from
9a7b4a1
to
c2bfb6d
Compare
|
Did you run the unit tests locally? |
|
@jrief Yes, I did. Since upgrading to Django 4.2 requires some settings changes, this change won't allow versions before 4.2. I hadn't added to the PR the changes to the GitHub workflows before. I pushed the updated workflow. Please, check it again. |
| @@ -13,14 +13,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.7", "3.8", "3.9", "3.10"] | |||
| django-version: ["2.2", "3.2", "4.0"] | |||
There was a problem hiding this comment.
Django versions 3.2 and 4.1 are not yet EOL, please check here: https://www.djangoproject.com/download/#supported-versions
This could break the build for many users.
There was a problem hiding this comment.
Moreover, if you change this settings, you should also change classifiers in setup.cfg.
There was a problem hiding this comment.
I removed Django 2.2 and added 4.1 and 4.2 to this workflow. I also changed setup.cfg to update the allowed Django versions.
bruunotrindade
force-pushed
the
master
branch
from
b659c41
to
2048348
Compare
|
Please change the version to 1.3 and document your changes in the Changelog, so that I can release a new version. |
As reported in #169 by @smoehrle, with the release of django 4.2 STATICFILES_STORAGE got deprecated in favor of STORAGES["staticfiles"].
Please, @jrief review this small pull request.