Fix compatibility with Django 5.1 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not import get_storage_class() which is deprecated since Django 4.2. 2048348 stopped using it on recent Django version but did not remove the import so sass_processor stopped working on the upcoming Django 5.1 which removes the get_storage_class() function.
|
I thought this would be covered by my previous commit (warnings catch by tests) but it did not as the DeprecationWarning is raised by Django on Anyway, I am testing compatibility of our project with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not import get_storage_class() which is deprecated since Django 4.2. 2048348 stopped using it on recent Django version but did not remove the import so sass_processor stopped working on the upcoming Django 5.1 which removes the get_storage_class() function.