Support VLAN links network_info.json #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With older versions of cloud-init (e.g. CentOS 7), it seemed to be possible to specify an interface named <link>.<vlan>, and cloud-init would assume that this is a VLAN interface on <link> with VLAN ID <vlan>. In more recent versions of cloud-init (e.g. CentOS 8), several additional parameters are required in more recent cloud-init versions: * vlan_id * vlan_link * vlan_mac_address While the MAC address is required, it does seem possible to set it to null. Additionally, the backend device must be listed in the configuration.
|
Looks ok! Merged. Thanks for the PR! |
|
Thanks! |
openstack-mirroring
pushed a commit
to openstack/kayobe
that referenced
this pull request
Jan 7, 2022
The jriguera.configdrive role does not add VLAN=yes to the ifcfg script of a VLAN interface on the seed VM, unless type=vlan is passed in the network device list. This change passes this field for VLAN interfaces. Depends on jriguera/ansible-role-configdrive#11 Change-Id: I6946b578f23843dd3cbafcb185b8d8cfbb00c080 Story: 2008089 Task: 40790
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 7, 2022
* Update kayobe from branch 'master'
to 6828184ab13193b85f7f1b34ff142b444696b4bc
- Merge "Fix seed VM configdrive when admin network is a VLAN"
- Fix seed VM configdrive when admin network is a VLAN
The jriguera.configdrive role does not add VLAN=yes to the ifcfg script
of a VLAN interface on the seed VM, unless type=vlan is passed in the
network device list. This change passes this field for VLAN interfaces.
Depends on jriguera/ansible-role-configdrive#11
Change-Id: I6946b578f23843dd3cbafcb185b8d8cfbb00c080
Story: 2008089
Task: 40790
openstack-mirroring
pushed a commit
to openstack/kayobe
that referenced
this pull request
Jan 10, 2022
The jriguera.configdrive role does not add VLAN=yes to the ifcfg script of a VLAN interface on the seed VM, unless type=vlan is passed in the network device list. This change passes this field for VLAN interfaces. Depends on jriguera/ansible-role-configdrive#11 Change-Id: I6946b578f23843dd3cbafcb185b8d8cfbb00c080 Story: 2008089 Task: 40790 (cherry picked from commit bc0885f)
openstack-mirroring
pushed a commit
to openstack/kayobe
that referenced
this pull request
Jan 10, 2022
The jriguera.configdrive role does not add VLAN=yes to the ifcfg script of a VLAN interface on the seed VM, unless type=vlan is passed in the network device list. This change passes this field for VLAN interfaces. Depends on jriguera/ansible-role-configdrive#11 Change-Id: I6946b578f23843dd3cbafcb185b8d8cfbb00c080 Story: 2008089 Task: 40790 (cherry picked from commit bc0885f)
openstack-mirroring
pushed a commit
to openstack/kayobe
that referenced
this pull request
Jan 24, 2022
The jriguera.configdrive role does not add VLAN=yes to the ifcfg script of a VLAN interface on the seed VM, unless type=vlan is passed in the network device list. This change passes this field for VLAN interfaces. Depends on jriguera/ansible-role-configdrive#11 Change-Id: I6946b578f23843dd3cbafcb185b8d8cfbb00c080 Story: 2008089 Task: 40790 (cherry picked from commit bc0885f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With older versions of cloud-init (e.g. CentOS 7), it seemed to be
possible to specify an interface named ., and cloud-init
would assume that this is a VLAN interface on with VLAN ID
.
In more recent versions of cloud-init (e.g. CentOS 8), several
additional parameters are required in more recent cloud-init versions:
While the MAC address is required, it does seem possible to set it to
null. Additionally, the backend device must be listed in the
configuration.