Use outermost threshold crossing point when detecting field edges #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves issue jrkerns#323 by switching to detecting the outermost points that cross the threshold value when detecting field edges in SingleProfile.
|
There's a bug in my implementation too. Will re-create once I have it sorted. |
jrkerns
added a commit
that referenced
this pull request
Jan 4, 2024
RAM-3146 Add planar scaling Approved-by: Randy Taylor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves issue #323 by switching to detecting the outermost points that cross the threshold value when detecting field edges in SingleProfile.
This patch keeps the current behaviour of using the index of the points below the threshold value.