Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix picket fence gui #371

Merged
merged 1 commit into from
Apr 29, 2021
Merged

fix picket fence gui #371

merged 1 commit into from
Apr 29, 2021

Conversation

alanphys
Copy link
Contributor

@jrkerns While doing routine QA I came across the following issue:

File "/usr/lib64/python3.8/tkinter/init.py", line 1895, in call
return self.func(*args)
File "/home/alanphys/Programs/pylinac/pylinac/py_gui.py", line 118, in analyze_pf
pf.analyze(tolerance=self.pf_tol.get(),
TypeError: analyze() got an unexpected keyword argument 'hdmlc'

I know you want to deprecate the gui but there are still some folk using it particularly in our company so I thought I would make this quick fix. I've deleted the hd_mlc checkbox and added a combobox with the different mlc types and passed the selected value as a parameter to the picketfence.init

I've only tested on HD mlc, but the others should work as there are no changes to the underlying code. The new MLC Arrangement is certainly much more flexible.
Regards
Alan

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 80.332% when pulling dc5b07c on alanphys:fixpfgui into 90f261b on jrkerns:master.

@jrkerns jrkerns merged commit 4d14eac into jrkerns:master Apr 29, 2021
@alanphys alanphys deleted the fixpfgui branch May 28, 2021 07:40
jrkerns added a commit that referenced this pull request Apr 9, 2024
#371)

v 3.21.1; Fix RAM-3483 VMAT ROI shift and identification

Approved-by: Randy Taylor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants