Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrkerns While doing routine QA I came across the following issue:
File "/usr/lib64/python3.8/tkinter/init.py", line 1895, in call
return self.func(*args)
File "/home/alanphys/Programs/pylinac/pylinac/py_gui.py", line 118, in analyze_pf
pf.analyze(tolerance=self.pf_tol.get(),
TypeError: analyze() got an unexpected keyword argument 'hdmlc'
I know you want to deprecate the gui but there are still some folk using it particularly in our company so I thought I would make this quick fix. I've deleted the hd_mlc checkbox and added a combobox with the different mlc types and passed the selected value as a parameter to the picketfence.init
I've only tested on HD mlc, but the others should work as there are no changes to the underlying code. The new MLC Arrangement is certainly much more flexible.
Regards
Alan