follow clear_borders setting in CTP404 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion; looks good. Is there a reason you closed it? |
|
There is - I hadn't thoroughly tested it, and realised there were some other instances of the setting being followed. I'll re-attempt the change and resubmit it. |
|
Apologies for the PR mess. I think this catches the rest of the cases where the clear_borders setting isn't used in the CatPhan analysis modules. |
|
I'll run against the test suite and add a few tests for this specifically, but looks straight-forward. Thanks! |
|
Tests pass. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #448
Use the clear_borders setting. There might also be scope for improving the edge/region detection to allow slightly blurrier edges, but I think this should be changed either way.