This repository has been archived by the owner on Feb 4, 2021. It is now read-only.
Adding PublicIds Parameter for the CloudinaryWrapper->resourcesByIds #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by_ids missing parameter
… the project and made the type of array as the sdk expects
Just a small fix to get the package discovery working (#47)
jrm2k6
approved these changes
May 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Looks like the publicIds parameter was missing from that function. I also adjusted the unit tests to account for the change. I'm not sure if this was expected, but after looking through the Cloudinary php sdk, it looks like that parameter is needed. We will need it for our purposes as well.
Thanks.