-
-
Notifications
You must be signed in to change notification settings - Fork 519
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
5 changed files
with
107 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,26 @@ | ||
|
||
<!-- | ||
# **TEMPLATE PLEASE EDIT** | ||
*Thank you for wanting to contribute! Please fill out this description as well | ||
as look at the checklist!* | ||
Thank you for wanting to contribute! | ||
Please fill out this description, and the checklist below. | ||
*Short block of text containing: | ||
- Relevant changes in text form | ||
- related issues | ||
- Motivation (if applicable) | ||
- Example of usage (if applicable) | ||
- Example of changes to config files (if applicable) | ||
* | ||
Here are some key points to include in your description: | ||
- What is this new code intended to do? | ||
- Are there any related issues? | ||
- What is the motivation for this change? | ||
- What is an example of usage, or changes to config files? (if applicable) | ||
--> | ||
|
||
### Checklist | ||
|
||
- [ ] The code change is tested and works locally. | ||
- [ ] Tests pass. Your PR cannot be merged unless tests pass. -- | ||
`poetry run behave` | ||
- [ ] The code passes linting via | ||
[black](https://black.readthedocs.io/en/stable/) (consistent code styling). -- | ||
`poetry run black --check . --verbose --diff` | ||
- [ ] The code passes linting via [pyflakes](https://launchpad.net/pyflakes) | ||
(logically errors and unused imports). -- `poetry run pyflakes jrnl features` | ||
- [ ] There is no commented out code in this PR. | ||
- [ ] Have you followed the guidelines in our Contributing document? | ||
- [ ] Have you checked to ensure there aren't other open | ||
[Pull Requests](../pulls) for the same update/change? | ||
- [ ] Have you added an explanation of what your changes do and why you'd like | ||
us to include them? | ||
- [ ] Have you written new tests for your core changes, as applicable? | ||
- [ ] I have read the [contributing doc](https://github.com/jrnl-org/jrnl/blob/develop/CONTRIBUTING.md). | ||
- [ ] I have included a link to the relevant issue number. | ||
- [ ] I have tested this code locally. | ||
- [ ] I have checked to ensure there aren't other open [pull requests](../pulls) | ||
for the same issue. | ||
- [ ] I have you written new tests for these changes, as needed. | ||
- [ ] All tests pass. | ||
<!-- | ||
NOTE: Your PR may not be reviewed if there are any failing tests. You can run | ||
tests locally with `make test` (see the contributing doc if you need help with | ||
`make`), or use our automated tests after you submit your PR. | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Stop | ||
|
||
Please don't file a blank issue. | ||
|
||
Fill out one of the templates from the link below and we'll be better able to | ||
help you. | ||
|
||
https://github.com/jrnl-org/jrnl/issues/new/choose |