Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Entry not saved" text doesn't appear in default stdin editor #1419

Closed
2 tasks
micahellison opened this issue Feb 26, 2022 · 0 comments · Fixed by #1459
Closed
2 tasks

"Entry not saved" text doesn't appear in default stdin editor #1419

micahellison opened this issue Feb 26, 2022 · 0 comments · Fixed by #1459
Labels
bug Something isn't working 📌 This can't go stale ready for pr Okay to start work. Feel free to ask questions.
Milestone

Comments

@micahellison
Copy link
Member

Bug Report

Environment

  • jrnl --diagnostic output:
jrnl: v2.8.4-beta2
Python: 3.8.2 (tags/v3.8.2:7b3ab59, Feb 25 2020, 23:03:10) [MSC v.1916 64 bit (AMD64)]
OS: Windows 10
  • Install method: pipx

Current Behavior

When you use the default editor (stdin) and enter nothing then press Ctrl+Z (or Ctrl+D on *nix), there's no message. However, when you use a configured editor and enter nothing then close it, it says "[Nothing saved to file]".

Expected Behavior

The user should see the same message for both input methods when nothing is saved to the journal.

Repro Steps

  • Ensure your config file editor key is blank
  • Type jrnl
  • Hit Ctrl+Z on Windows or Ctrl+D on *nix

Other Information

A resolution should have:

  • A message indicating nothing was saved when the user doesn't enter anything using the default editor
  • A BDD test that confirms that the message appears in this situation
@micahellison micahellison added bug Something isn't working 🆕 New! 📌 This can't go stale ready for pr Okay to start work. Feel free to ask questions. and removed 🆕 New! labels Feb 26, 2022
@micahellison micahellison added this to the Backlog milestone Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📌 This can't go stale ready for pr Okay to start work. Feel free to ask questions.
Projects
None yet
1 participant