Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "No entry to save, because no text was received" after empty entry on cmdline #1459

Merged
merged 2 commits into from Apr 30, 2022

Conversation

apainintheneck
Copy link
Contributor

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

This PR fixes the bug mentioned in #1419. Now when the user enters an empty journal entry they get the message [Entry not saved] back whether they entered it at the command line or using an editor.

Closes #1419.

@wren wren changed the title Display "Entry not saved" after empty entry on cmdline Display "No entry to save, because no text was received" after empty entry on cmdline Apr 30, 2022
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I just made a quick update to the error message (you did it correctly, we just changed our mind on the wording).

Thank you!

@wren wren merged commit d6d6db0 into jrnl-org:develop Apr 30, 2022
@wren wren added the bug Something isn't working label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Entry not saved" text doesn't appear in default stdin editor
2 participants