Linting rules aren't enforced the same as format rules

[micahellison]

Diagnostic output

n/a - this is a dev issue

Current Behavior

Our linter isn't consistently checking for the same rules that black is running.

Expected Behavior

We expect to catch formatting issues in a poe test run or through C/I, rather than always having to remember to run poe format.

Repro Steps

One rule that isn't consistent is the line length rule. Here's how to repro:

Add a line to a .py file in the jrnl folder like so:

print("Testing a very long line") # here is a long enough line with a comment at the end, so black will indent it

Run poe lint

It will pass, but it shouldn't.

Run poe format and it will change into a state that should pass:

print(
    "Testing a very long line"
)  # here is a long enough line with a comment at the end, so black will indent it

Debug output

n/a

Other Information

Might be worth switching to a different linter. Maybe ruff, which runs much faster than flakeheaven.

[micahellison]

I'm playing around with ruff and I like it, however its docs mention that it omits "those stylistic rules made obsolete by the use of an autoformatter, like Black".

The real solution to this issue is to add black --check to our linting step.