Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing of DayOne entries #1001

Merged
merged 4 commits into from
Jul 18, 2020
Merged

Allow editing of DayOne entries #1001

merged 4 commits into from
Jul 18, 2020

Commits on Jul 2, 2020

  1. add test to repro issue jrnl-org#955

    @wren
    wren committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    6f7c538 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Allow editing of DayOne entries

    @MinchinWeb
    MinchinWeb committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    07bacab View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2020

  1. Add broken test for Dayone 

    Add test for editing Dayone entries (this test currently fails)

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
    @micahellison @wren
    micahellison and wren committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    efd5152 View commit details
    Browse the repository at this point in the history

  2. Fix editing logic for DayOneJournal 

    DayOneJournal previously reimplemented Journal._parse inside of
DayOneJournal.parse_editable_string, and in doing so caused issues
between itself and the class it was inheriting from. This commit fixes
the issue by moving the UUID to be in the body of the entry, rather than
above it. So, then Journal._parse still finds the correct boundaries
between entries, and DayOneJournal then parses the UUID afterward.

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
    @wren @micahellison
    wren and micahellison committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    966ea59 View commit details
    Browse the repository at this point in the history