Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency (packaging) #1011

Merged
merged 1 commit into from Jul 29, 2020
Merged

Add missing dependency (packaging) #1011

merged 1 commit into from Jul 29, 2020

Conversation

wren
Copy link
Member

@wren wren commented Jul 29, 2020 •
edited

Fixes #1010

packaging was missing from our latest release (only included in our dev dependencies). Our tests missed it because they all have dev deps installed. This PR adds the missing dep, and we'll deal with the test suite separately.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@wren wren changed the title Add missing dependency Add missing dependency (packaging) Jul 29, 2020
@wren wren changed the base branch from develop to master July 29, 2020 19:12
@wren wren changed the base branch from master to release July 29, 2020 19:13
@wren wren mentioned this pull request Jul 29, 2020
Closed
6 tasks
micahellison
micahellison approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦🎉

@micahellison micahellison added the bug Something isn't working label Jul 29, 2020
@micahellison micahellison merged commit 832b922 into jrnl-org:release Jul 29, 2020
@wren wren deleted the dep-packaging-1010 branch July 29, 2020 22:24
@wren wren mentioned this pull request Jul 29, 2020
Closed
wren added a commit that referenced this pull request Oct 17, 2020
@wren
Add missing packaging dependency (#1011)
0c9e4f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First run of jrnl, getting ModuleNotFoundError
2 participants
@wren @micahellison