Resolve Travis/Windows/pip issues with upgrade to cryptography 3.0 #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llison/jrnl into cryptography-windows-1009
micahellison
changed the title
micahellison
changed the title
micahellison
changed the title
wren
added a commit
that referenced
this pull request
Oct 17, 2020
…1016) * add missing dependency * update cryptography dependency * Installing poetry with pipx instead of pip * Fix bad pipx install command * Remove pipx commands and attempt to solve issue through poetry configuration * Fix pip install command to include --upgrade as before Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the upgrade to cryptography 3.0 (#1012) and fixes the Windows build issues that resulted from that upgrade.
It turns out that, for some reason, telling poetry to store its virtual environment inside the project folder prevents the Windows access issues that prevented poetry (and the version of pip it's running) from working elsewhere within the user's folder.
Checklist
for the same issue. (note: this is based on Update dependency (cryptography) #1012)