Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable logging by default #1053

Merged
merged 2 commits into from Oct 10, 2020
Merged

Disable logging by default #1053

merged 2 commits into from Oct 10, 2020

Conversation

wren
Copy link
Member

@wren wren commented Oct 10, 2020

Fixes #1048.

This disables all logging unless the --debug flag is given

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • [n/a] I have written new tests for these changes, as needed.
  • All tests pass.

@wren wren added the bug Something isn't working label Oct 10, 2020
@micahellison micahellison merged commit 171ce34 into jrnl-org:develop Oct 10, 2020
wren added a commit that referenced this pull request Oct 17, 2020
@wren @micahellison
Disable logging by default (#1053)
b8f3b03 
* disable logging by default (only enabled if --debug flag is given)

* Run make format

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
@wren wren deleted the empty-file-error-1048 branch October 18, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra error when writing empty entry
2 participants
@wren @micahellison