Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add circle ci config file for linux tests #1063

Merged
merged 3 commits into from Oct 28, 2020
Merged

Add circle ci config file for linux tests #1063

merged 3 commits into from Oct 28, 2020

Conversation

wren
Copy link
Member

@wren wren commented Oct 26, 2020 •
edited

Starting work on #1060

This adds the circle ci config file, and runs linux tests, and linting (no mac or windows, yet).

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@wren
Add circle ci config file for linux tests
d766c65
@wren
Moved repeated commands into commands section for reuse in jobs
07558cc 
Circle apparently allows you to separate custom commands into their own
key, and then reuse them at will in jobs.
micahellison
micahellison approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪©👁

@wren wren added the build Issues related to the build pipeline label Oct 28, 2020
@wren wren merged commit 9e72d10 into jrnl-org:develop Oct 28, 2020
@wren wren deleted the circle-ci-1060 branch October 28, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wren @micahellison