Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual header to readme #1085

Merged
merged 3 commits into from Nov 21, 2020
Merged

Add visual header to readme #1085

merged 3 commits into from Nov 21, 2020

Conversation

wren
Copy link
Member

@wren wren commented Nov 16, 2020

It's just a screenshot from the website, but it's a start to make the readme look a bit nicer. Also, the picture of the terminal quickly shows what jrnl is about.

Note: The img element requires an absolute path here, so I've hardcoded it to the develop branch, so it wont be visible in the preview until this is merged. You can preview the readme file locally, if you check out the branch, and change the url to the local file included in this branch.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@github-actions

This comment has been minimized.

@jrnl-org jrnl-org deleted a comment from github-actions bot Nov 19, 2020
@github-actions

This comment has been minimized.

Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📔

@micahellison micahellison merged commit 514ee30 into jrnl-org:develop Nov 21, 2020
@micahellison micahellison added the documentation Improvements or additions to documentation label Nov 21, 2020
@github-actions
Copy link

Unit Test Results

  16 files  ±0    16 suites  ±0   9s ⏱️ -2s
274 tests  - 6  274 ✔️  - 6  0 💤 ±0  0 ❌ ±0 
275 runs   - 6  275 ✔️  - 6  0 💤 ±0  0 ❌ ±0 

results for commit 514ee30 ± comparison against base commit 8ec661b

@wren wren changed the title Add logo to readme Add visual header to readme Nov 21, 2020
@wren wren deleted the readme-logo branch November 28, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants