Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unicode encoding failure in directory export when creating filenames from journal titles with certain characters #1090

Merged
merged 5 commits into from Nov 21, 2020

Conversation

micahellison
Copy link
Member

Fixes #1089.

It turns out that strftime doesn't play nicely with all Unicode characters. I think this is a Windows-specific issue, but I'm not sure, and we're testing on all platforms anyway. This PR modifies the directory export's file name builder to use strftime to handle only the date part of the filename, then append the rest of the string, which may contain just about any character.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@github-actions

This comment has been minimized.

@wren wren force-pushed the develop branch 2 times, most recently from 807e58e to 142e6f5 Compare November 21, 2020 23:08
@micahellison micahellison added the bug Something isn't working label Nov 21, 2020
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…mes from journal titles with certain characters
@github-actions

This comment has been minimized.

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎐

@github-actions
Copy link

Unit Test Results

  16 files  ±0    16 suites  ±0   9s ⏱️ -1s
278 tests  - 6  278 ✔️  - 6  0 💤 ±0  0 ❌ ±0 
279 runs   - 6  279 ✔️  - 6  0 💤 ±0  0 ❌ ±0 

results for commit 259a607 ± comparison against base commit 046ebc7

@wren wren merged commit b511461 into jrnl-org:develop Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants