Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More changelog fixes #1092

Merged
merged 7 commits into from Nov 21, 2020
Merged

More changelog fixes #1092

merged 7 commits into from Nov 21, 2020

Conversation

wren
Copy link
Member

@wren wren commented Nov 21, 2020 •
edited

More work on #1060

This is hard to test without running it on Github Actions a few times.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

micahellison
micahellison approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@wren wren merged commit d68b9e1 into jrnl-org:develop Nov 21, 2020
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Unit Test Results

  16 files  ±0    16 suites  ±0   15s ⏱️ +5s
280 tests ±0  280 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
281 runs  ±0  281 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

results for commit d68b9e1 ± comparison against base commit 142e6f5

@wren wren added the build Issues related to the build pipeline label Nov 21, 2020
@wren wren deleted the changelog-1060 branch November 21, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wren @micahellison