Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with GPL by acknowledging all authors and including license info in each source file #1121

Merged
merged 13 commits into from Dec 19, 2020

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Dec 19, 2020

This PR ensures that we're complying with the GPLv3 license by properly attribution authorship to all jrnl contributors. It also includes the copyright and license in each source file.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@@ -4,13 +4,13 @@ Feature: Functionality of jrnl outside of actually handling journals
Given we use the config "simple.yaml"
When we run "jrnl --version"
Then we should get no error
Then the output should match "^jrnl version v\d+\.\d+(\.\d+)?(-(alpha|beta))?$"
Then the output should match "^jrnl version v\d+\.\d+(\.\d+)?(-(alpha|beta)\d*)?"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

  16 files    16 suites   8s ⏱️
289 tests 289 ✔️ 0 💤 0 ❌
290 runs  290 ✔️ 0 💤 0 ❌

results for commit de54a12

@wren wren added the documentation Improvements or additions to documentation label Dec 19, 2020
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍡

@wren wren merged commit c572942 into jrnl-org:develop Dec 19, 2020
wren pushed a commit that referenced this pull request Dec 20, 2020
…fo in each source file (#1121)

* Update authors to "jrnl contributors" to comply with GPL3
* Include jrnl email address with contributors
* Include GPL notice in jrnl --version
* Apply consistent copyright and license to all Python files
* Add copyright and license to documentation
* Add copyright and license to docs theme
* Wiping poetry cache to try to resolve a test issue
* Testing with Python 3.9.0 in attempt to bypass GitHub Actions failure in 3.9.1
* make format
* Exclude Windows Python 3.9 build which is failing due to a GitHub Actions problem
* Modify testing to get around this 3.9 issue...
* Fix exclude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants