Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OS compatibility issues for editors with spaces, slashes, and quotes #1153

Merged
merged 5 commits into from Jan 16, 2021
Merged

Fix OS compatibility issues for editors with spaces, slashes, and quotes #1153

merged 5 commits into from Jan 16, 2021

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Jan 16, 2021 •
edited

Fixes #1151 and #1096. Relates to #581.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@micahellison micahellison marked this pull request as draft January 16, 2021 20:43
@micahellison micahellison changed the title [WIP] Fix OS compatibility issues for editors with spaces, slashes, and quotes Fix OS compatibility issues for editors with spaces, slashes, and quotes Jan 16, 2021
@micahellison micahellison marked this pull request as ready for review January 16, 2021 22:43
@micahellison micahellison added the bug Something isn't working label Jan 16, 2021
wren
wren approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

@wren wren merged commit 9e6cd88 into jrnl-org:develop Jan 16, 2021
@micahellison micahellison mentioned this pull request Jan 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shlex.split usage for editor config with commands that have spaces
2 participants
@micahellison @wren