Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove __init__.py files #1275

Merged
merged 1 commit into from Jun 26, 2021
Merged

Remove __init__.py files #1275

merged 1 commit into from Jun 26, 2021

Conversation

wren
Copy link
Member

@wren wren commented Jun 26, 2021 •
edited

Since we're implementing a plugin system that relies on implicit namespace packages, we should remove these files so that they don't confuse and muddle our virtual envs (like the ones we use to run tests). Also, they're no longer needed as of Python 3.3.

PEP 420 says "Allowing implicit namespace packages means that the requirement to provide an init.py file can be dropped completely..."

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@wren
Remove __init__.py files
6c191f2 
Since we're implementing a plugin system that relies on implicit
namespacing, we should remove these files so that they don't confuse and
muddle our virtual envs (like the ones we use to run tests).

Also, they're not longer needed as of Python 3.3.

PEP 420 says:
Allowing implicit namespace packages means that the requirement to
provide an __init__.py file can be dropped completely...
micahellison
micahellison approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@micahellison micahellison merged commit e0536e7 into jrnl-org:feature-plugins Jun 26, 2021
@micahellison micahellison deleted the plugins-implicit-namespace branch June 26, 2021 21:54
@wren wren added the build Issues related to the build pipeline label Jun 26, 2021
This was referenced Jun 27, 2021
Merged
Closed
Closed
wren added a commit that referenced this pull request Jul 17, 2021
@wren
Remove __init__.py files (#1275)
c5c859d 
Since we're implementing a plugin system that relies on implicit
namespacing, we should remove these files so that they don't confuse and
muddle our virtual envs (like the ones we use to run tests).

Also, they're not longer needed as of Python 3.3.

PEP 420 says:
Allowing implicit namespace packages means that the requirement to
provide an __init__.py file can be dropped completely...
wren added a commit that referenced this pull request Jul 17, 2021
@wren
Remove __init__.py files (#1275)
be1da17 
Since we're implementing a plugin system that relies on implicit
namespacing, we should remove these files so that they don't confuse and
muddle our virtual envs (like the ones we use to run tests).

Also, they're not longer needed as of Python 3.3.

PEP 420 says:
Allowing implicit namespace packages means that the requirement to
provide an __init__.py file can be dropped completely...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wren @micahellison