Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show name of journal when creating a password/encrypting #1478

Merged
merged 10 commits into from
May 21, 2022
Merged

Show name of journal when creating a password/encrypting #1478

merged 10 commits into from
May 21, 2022

Conversation

jonakeys
Copy link
Contributor

This code intends to make it clearer which journal you are trying to encrypt/generate a password for. The original code said 'new journal', but it would be better if the actual name of the journal is shown at the prompt.

I couldn't find an issue number related to this change. And because it only changes the prompt I didn´t write a test for it.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@wren wren added the enhancement New feature or request label May 21, 2022
@wren wren merged commit 86c8466 into jrnl-org:develop May 21, 2022
@jonakeys jonakeys deleted the passprmptnamejrnl branch May 21, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants