Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Poetry caching for accessibility tests #1505

Merged
merged 1 commit into from Jun 18, 2022

Conversation

wren
Copy link
Member

@wren wren commented Jun 12, 2022

The cache key was changed a while back, and we left out the accessibility tests. The tests still ran, but no longer cached the installed packages through poetry, resulting in slower tests. This PR fixes it, and should speed up the accessibility tests.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the build Issues related to the build pipeline label Jun 18, 2022
@micahellison micahellison merged commit fe2b976 into jrnl-org:develop Jun 18, 2022
@micahellison micahellison deleted the fix-cache-a11y-tests branch June 18, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants