Export to file(s) when first line/title of an entry is very long #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests on Windows failed, so back to the drawing board it is. |
|
All checks have passed! PR is open for reviewing. |
micahellison
requested changes
Jul 30, 2022
There was a problem hiding this comment.
Hi @jonakeys, thanks for working on this and for your patience in waiting for a review. I've got just a couple small nitpicks.
micahellison
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1272 When a journal has a long first line/title, it now exports to a (truncated) file name without throwing an error.
Also added tests for markdown and text formats.
Checklist
for the same issue.
Fixes #1272