Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actionlint to testing pipelines #1555

Merged
merged 8 commits into from Aug 21, 2022

Conversation

wren
Copy link
Member

@wren wren commented Aug 16, 2022

This PR adds actionlint to the testing pipelines. This will allow us to test changes to Github Actions before they are committed into the develop branch, and will alert us about common problems much sooner. It also fixes all linting issues currently in the pipeline files so that we don't have a bunch of warnings right from the start.

I also recommend actionlint to anyone working on Github Actions (it's a very useful tool).

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the build Issues related to the build pipeline label Aug 21, 2022
@micahellison micahellison merged commit 803b395 into jrnl-org:develop Aug 21, 2022
@micahellison micahellison deleted the actionlint-pipeline branch August 21, 2022 20:59
@wren wren mentioned this pull request Aug 27, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants