Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress "Entry added" message if using default journal #1561

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

micahellison
Copy link
Member

This PR fixes #1543 by suppressing output if you successfully add a new entry to your default journal.

If you're working on any other journal, it will still show the message. I hope this is a good compromise for jrnl's default behavior, though I think it's also worth revisiting later to see if we're best saved by a "quiet" or "verbose" mode.

Example of this behavior:

>jrnl this is a new entry to my default journal
>jrnl testing this is a new entry to my testing journal
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃  Entry added to testing journal  ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
>jrnl testign I wanted this to be a new entry in my testing journal but I misspelled the journal name
>

Feedback welcome!

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

@wren wren added the enhancement New feature or request label Aug 27, 2022
@wren wren merged commit f65f07d into jrnl-org:develop Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supress output if action is successful
2 participants