Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docs Accessibility Testing #1588

Merged
merged 3 commits into from Sep 3, 2022
Merged

Fix Docs Accessibility Testing #1588

merged 3 commits into from Sep 3, 2022

Conversation

wren
Copy link
Member

@wren wren commented Sep 3, 2022

The latest docs accessibility testing pipeline is passing even when the testing itself fails (example). This fixes that bug so that the pipeline actually fails, too.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@wren wren added the build Issues related to the build pipeline label Sep 3, 2022
@micahellison micahellison merged commit bd02c52 into jrnl-org:develop Sep 3, 2022
@micahellison micahellison deleted the fix-docs-tests branch September 3, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wren @micahellison