Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that editors must be blocking processes #1624

Merged
merged 4 commits into from
Oct 29, 2022
Merged

Document that editors must be blocking processes #1624

merged 4 commits into from
Oct 29, 2022

Conversation

micahellison
Copy link
Member

Fixes #1456. Updates documentation to specify that editors must be blocking processes.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

wren
wren approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️

@wren wren merged commit 6f9a3eb into jrnl-org:develop Oct 29, 2022
@micahellison micahellison deleted the docs-editor-blocking-1456 branch October 29, 2022 19:14
@wren wren added the documentation Improvements or additions to documentation label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation about how the editor must be a blocking process
2 participants
@micahellison @wren